Opened 4 years ago
Last modified 4 years ago
#23462 new enhancement
Square roots that create extensions (extend=True as for integers) for rational number field
Reported by:  davidayotte  Owned by:  davidayotte 

Priority:  minor  Milestone:  sage8.1 
Component:  number fields  Keywords:  square roots, number field, sd87 
Cc:  klui  Merged in:  
Authors:  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  u/davidayotte/square_roots_that_create_extensions__extend_true_as_for_integers__for_rational_number_field (Commits, GitHub, GitLab)  Commit:  740fd548e3453a83fc2b01a0de3135ab7bd1eac6 
Dependencies:  Stopgaps: 
Description (last modified by )
We are implementing square roots that create extensions for elements in rational number field. The code should return the equivalent of the element b in the code below :
sage: P.<x> = QQ[] sage: K.<a> = NumberField(x^2  7) sage: Q.<y> = K[] sage: E.<b> = K.extension(y^2  a) sage: b^2 a
Change History (10)
comment:1 Changed 4 years ago by
 Type changed from PLEASE CHANGE to enhancement
comment:2 Changed 4 years ago by
 Description modified (diff)
 Owner changed from (none) to davidayotte
comment:3 Changed 4 years ago by
 Branch set to u/davidayotte/square_roots_that_create_extensions__extend_true_as_for_integers__for_rational_number_field
comment:4 Changed 4 years ago by
 Commit set to a5d2d407abd4ede4daca22dc54d0f9b00c7f818b
comment:5 Changed 4 years ago by
 Cc klui added
comment:6 Changed 4 years ago by
 Commit changed from a5d2d407abd4ede4daca22dc54d0f9b00c7f818b to 2d98ff34c890fbc87822e63c06648b64ea6c1e4c
Branch pushed to git repo; I updated commit sha1. New commits:
2d98ff3  the user can now specify the name of the square root

comment:7 Changed 4 years ago by
 Commit changed from 2d98ff34c890fbc87822e63c06648b64ea6c1e4c to 92b105714844ee2fe2aa44eb792e93f9b86e7baf
Branch pushed to git repo; I updated commit sha1. New commits:
92b1057  nth root that create extension but it does not work

comment:8 Changed 4 years ago by
 Commit changed from 92b105714844ee2fe2aa44eb792e93f9b86e7baf to 1779b637d75460808bea947d60f4a4e547711cb3
Branch pushed to git repo; I updated commit sha1. New commits:
1779b63  implemented nth root that create extension and add doctest

comment:9 Changed 4 years ago by
I don't think it's the best algorithm, because it's kind of slow.
comment:10 Changed 4 years ago by
 Commit changed from 1779b637d75460808bea947d60f4a4e547711cb3 to 740fd548e3453a83fc2b01a0de3135ab7bd1eac6
Branch pushed to git repo; I updated commit sha1. New commits:
740fd54  Square roots and nth roots working

Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. New commits:
added some doctest