#StackBounty: #php #menus #navigation #walker Custom Walker_Nav_Menu issue with variables on PHP 7.3

Bounty: 100

I’ve made this custom walker that extends Walker_Nav_Menu for “mega menu” implemenation. It works perfectly fine from PHP 5.4 to PHP 7.2, however it stops working (or randomly starts to work) on PHP 7.3

class custom_theme_megamenu_walker extends Walker_Nav_Menu
{
   /**
     * What the class handles.
     *
     * @see Walker::$tree_type
     * @since 3.0.0
     * @var string
     */
    var $tree_type = array( 'post_type', 'taxonomy', 'custom' );

    /**
     * Database fields to use.
     *
     * @see Walker::$db_fields
     * @since 3.0.0
     * @todo Decouple this.
     * @var array
     */
    var $db_fields = array( 'parent' => 'menu_item_parent', 'id' => 'db_id' );

    //save current item so it can be used in start level
    private $curItem;
    private $curLvl;
    private $megamenu;
    /**
     * Starts the list before the elements are added.
     *
     * @see Walker::start_lvl()
     *
     * @since 3.0.0
     *
     * @param string $output Passed by reference. Used to append additional content.
     * @param int    $depth  Depth of menu item. Used for padding.
     * @param array  $args   An array of arguments. @see wp_nav_menu()
     */
    function start_lvl( &$output, $depth = 0, $args = array() ) {
          $indent = str_repeat("t", $depth);

            $megamenu = get_post_meta( $this->curItem->ID, '_menu-item-megamenu', true);
            $megamenu_width = get_post_meta( $this->curItem->ID, '_menu-item-columns', true);

            if($depth === 1) {

                $tag = "ul";
            } else {
                $tag = "ul";
            }

            if($megamenu) {

                $output .= "n$indent
    n"; } else { $output .= "n$indentn"; } } /** * Ends the list of after the elements are added. * * @see Walker::end_lvl() * * @since 3.0.0 * * @param string $output Passed by reference. Used to append additional content. * @param int $depth Depth of menu item. Used for padding. * @param array $args An array of arguments. @see wp_nav_menu() */ function end_lvl( &$output, $depth = 0, $args = array() ) { $indent = str_repeat("t", $depth); $megamenu = get_post_meta( $this->curItem->ID, '_menu-item-megamenu', true); if($depth === 1) { if($megamenu) { $output .= "n$indent
n"; } else { $output .= "n$indentn"; } } else { if($megamenu) { $output .= "n$indentn"; } else { $output .= "n$indentn"; } } } /** * Start the element output. * * @see Walker::start_el() * * @since 3.0.0 * * @param string $output Passed by reference. Used to append additional content. * @param object $item Menu item data object. * @param int $depth Depth of menu item. Used for padding. * @param array $args An array of arguments. @see wp_nav_menu() * @param int $id Current item ID. */ function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) { $indent = ( $depth ) ? str_repeat( "t", $depth ) : ''; //save current item to private curItem to use it in start_lvl $this->curItem = $item; $class_names = ''; $this->megamenu = get_post_meta( $item->ID, '_menu-item-megamenu', true); $classes = empty( $item->classes ) ? array() : (array) $item->classes; $classes[] = 'menu-item-' . $item->ID; $classes[] = 'parentid'.get_post_meta( $item->ID, '_menu_item_menu_item_parent', true); /** * Filter the CSS class(es) applied to a menu item's
  • . * * @since 3.0.0 * * @see wp_nav_menu() * * @param array $classes The CSS classes that are applied to the menu item's
  • . * @param object $item The current menu item. * @param array $args An array of wp_nav_menu() arguments. */ $hiddenstatus = get_post_meta( $item->ID, '_menu-item-hiddenonmobile', true); if($hiddenstatus == 'hide') { $classes[] = 'hidden-on-mobile'; } $classes[] = 'depth'.$depth; if($depth === 0 && $this->megamenu != '') { $classes[] = 'has-megamenu'; } else { $classes[] = 'dropdown'; } if($depth === 1) { $parent = get_post_meta( $item->ID, '_menu_item_menu_item_parent', true); $parent_has_megamenu = get_post_meta( $parent, '_menu-item-megamenu', true); if ($parent_has_megamenu == '_blank') { $widthclass = get_post_meta( $item->ID, '_menu-item-columns', true); $classes[] = $widthclass; } } $class_names = join( ' ', apply_filters( 'nav_menu_css_class', array_filter( $classes ), $item, $args ) ); $class_names = $class_names ? ' class="' . esc_attr( $class_names ) . '"' : ''; /** * Filter the ID applied to a menu item's
  • . * * @since 3.0.1 * * @see wp_nav_menu() * * @param string $menu_id The ID that is applied to the menu item's
  • . * @param object $item The current menu item. * @param array $args An array of wp_nav_menu() arguments. */ $id = apply_filters( 'nav_menu_item_id', 'menu-item-'. $item->ID, $item, $args ); $id = $id ? ' id="' . esc_attr( $id ) . '"' : ''; $output .= $indent . '
  • '; $atts = array(); $atts['title'] = ! empty( $item->attr_title ) ? $item->attr_title : ''; $atts['target'] = ! empty( $item->target ) ? $item->target : ''; $atts['rel'] = ! empty( $item->xfn ) ? $item->xfn : ''; $atts['href'] = ! empty( $item->url ) ? $item->url : ''; /** * Filter the HTML attributes applied to a menu item's . * * @since 3.6.0 * * @see wp_nav_menu() * * @param array $atts { * The HTML attributes applied to the menu item's , empty strings are ignored. * * @type string $title Title attribute. * @type string $target Target attribute. * @type string $rel The rel attribute. * @type string $href The href attribute. * } * @param object $item The current menu item. * @param array $args An array of wp_nav_menu() arguments. */ $atts = apply_filters( 'nav_menu_link_attributes', $atts, $item, $args ); $is_clickable = get_post_meta($item->object_id, 'link_disabled', true); $jsarg = ($is_clickable == '1') ? 'onclick="return false;"' : ''; $attributes = ''; foreach ( $atts as $attr => $value ) { if ( ! empty( $value ) ) { $value = ( 'href' === $attr ) ? esc_url( $value ) : esc_attr( $value ); $attributes .= ' ' . $attr . '="' . $value . '"'; } } $linkrole = get_post_meta( $item->ID, '_menu-item-linkrole', true); $item_output = $args->before; $icon = get_post_meta( $item->ID, '_menu-item-icon', true); if(!empty($icon)){ if(substr($icon,0, 2) == 'ln'){ $icon = ' '; } else { $icon = ' '; } } if($depth === 1 ) { if($linkrole == 'title' ) { $item_output .= $args->link_before .''.$icon. apply_filters( 'the_title', $item->title, $item->ID ) .''. $args->link_after; } elseif($linkrole == 'paragraph') { $content = get_post_meta( $item->ID, '_menu-item-html', true); $item_output .= ''; $item_output .= $args->link_before; $item_output .= do_shortcode($content); $item_output .= $args->link_after; $item_output .= '

    '; } elseif($linkrole == 'paragraphtitle') { $content = get_post_meta( $item->ID, '_menu-item-html', true); $item_output .= ''; $item_output .= $args->link_before .''.$icon. apply_filters( 'the_title', $item->title, $item->ID ) .''; $item_output .= do_shortcode($content); $item_output .= $args->link_after; $item_output .= '

    '; } else if($linkrole == 'hidden') { } else { $item_output .= '
    '; $item_output .= $args->link_before .$icon. apply_filters( 'the_title', $item->title, $item->ID ) . $args->link_after; $item_output .= ''; } } elseif( $depth === 0 ) { $item_output .= ''; $item_output .= $args->link_before .$icon. apply_filters( 'the_title', $item->title, $item->ID ) . $args->link_after; $item_output .= ''; } else { $item_output .= ''; $item_output .= $args->link_before .$icon. apply_filters( 'the_title', $item->title, $item->ID ) . $args->link_after; $item_output .= ''; } /* if($depth === 0 && $this->megamenu != '') { $item_output .= '
    '; }*/ $item_output .= $args->after; /** * Filter a menu item's starting output. * * The menu item's starting output only includes $args->before, the opening , * the menu item's title, the closing , and $args->after. Currently, there is * no filter for modifying the opening and closing
  • for a menu item. * * @since 3.0.0 * * @see wp_nav_menu() * * @param string $item_output The menu item's starting HTML output. * @param object $item Menu item data object. * @param int $depth Depth of menu item. Used for padding. * @param array $args An array of wp_nav_menu() arguments. */ $output .= apply_filters( 'walker_nav_menu_start_el', $item_output, $item, $depth, $args ); } /** * Ends the element output, if needed. * * @see Walker::end_el() * * @since 3.0.0 * * @param string $output Passed by reference. Used to append additional content. * @param object $item Page data object. Not used. * @param int $depth Depth of page. Not Used. * @param array $args An array of arguments. @see wp_nav_menu() */ function end_el( &$output, $item, $depth = 0, $args = array() ) { $this->megamenu = get_post_meta( $item->ID, '_menu-item-megamenu', true); if($depth === 0 && $this->megamenu != '') { $output .= "
  • n"; } else { $output .= "</li>n"; } } }

    I try to assign the $curItem and &curLvl to know which elements holds the megemenu, and on which end_lvl it ends to be able to close it correctly (megamenu is in div instead of ul). on PHP 7.3 it randomly works, once in few tries the variable matches, but in most cases it looks like it doesn’t assign it correctly. Can anyone point me what has changed in PHP 7.3 that could affect it?

    Thanks


    Get this bounty!!!

    Leave a Reply

    This site uses Akismet to reduce spam. Learn how your comment data is processed.